-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Separate extensive vector search tests and run them on push to dev and main vec-373 #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #52 +/- ##
======================================
Coverage ? 71.44%
======================================
Files ? 25
Lines ? 2241
Branches ? 0
======================================
Hits ? 1601
Misses ? 640
Partials ? 0 ☔ View full report in Codecov by Sentry. |
DomPeliniAerospike
approved these changes
Oct 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
A solid improvement.
dwelch-spike
added a commit
that referenced
this pull request
Oct 14, 2024
* feat: vec-327 add field_exclusions optional parameter to client.get and client.vector_search() to filer out fields returned by the AVS server * feat: vec-327 deprecate field_names .get() and .vector_search() argument. Add include_fields and exclude_fields arguments to those functions. fix: issue where an empty list used as field_names argument would still include all result fields. * feat: Add vector_search_by_key method to sync and async clients vec-330 (#53) * test: add tests with empty include_fields argument * chore: check that __eq__ is being used with the same class in Key type * remove extra type hints * review changes pt1 * review changes pt2, only assign projection filter fields once * docs: document Key argument, set, as string type * ci: collect and upload test coverage to coddecov vec-337 (#50) * ci: Separate extensive vector search tests and run them on push to dev and main vec-373 (#52) * ci: split extensive vector search tests into another file * ci: trigger extensive vector search tests on push to dev and main only * ci: separate is_indexed and extensive vector search tests --------- Co-authored-by: Dominic Pelini <[email protected]> Co-authored-by: Dominic Pelini <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to reduce test runtimes on PRs.